no-unsafe-finally

Disallow control flow statements in finally blocks

JavaScript 会暂停 try 和 catch 块的控制流语句，直到finally 块执行完毕。因此，当 return、throw、break 或 continue 在 finally 中使用时，try 和 catch 中的控制流语句会被覆盖，这被认为是意外行为。比如：

// We expect this function to return 1;
(() => {
    try {
        return 1; // 1 is returned but suspended until finally block ends
    } catch(err) {
        return 2;
    } finally {
        return 3; // 3 is returned before 1, which we did not expect
    }
})();

// > 3
1
2
3
4
5
6
7
8
9
10
11
12

// We expect this function to throw an error, then return
(() => {
    try {
        throw new Error("Try"); // error is thrown but suspended until finally block ends
    } finally {
        return 3; // 3 is returned before the error is thrown, which we did not expect
    }
})();

// > 3
1
2
3
4
5
6
7
8
9
10

// We expect this function to throw Try(...) error from the catch block
(() => {
    try {
        throw new Error("Try")
    } catch(err) {
        throw err; // The error thrown from try block is caught and rethrown
    } finally {
        throw new Error("Finally"); // Finally(...) is thrown, which we did not expect
    }
})();

// > Uncaught Error: Finally(...)
1
2
3
4
5
6
7
8
9
10
11
12

// We expect this function to return 0 from try block.
(() => {
  label: try {
    return 0; // 0 is returned but suspended until finally block ends
  } finally {
    break label; // It breaks out the try-finally block, before 0 is returned.
  }
  return 1;
})();

// > 1
1
2
3
4
5
6
7
8
9
10
11

规则细节

使用此规则禁用 return, throw, break, 和 continue 语句。在 finally 块内。它允许间接使用，例如在 function 或 class 定义中。

使用此规则的错误示例：

/*eslint no-unsafe-finally: "error"*/
let foo = function() {
    try {
        return 1;
    } catch(err) {
        return 2;
    } finally {
        return 3;
    }
};
1
2
3
4
5
6
7
8
9
10

/*eslint no-unsafe-finally: "error"*/
let foo = function() {
    try {
        return 1;
    } catch(err) {
        return 2;
    } finally {
        throw new Error;
    }
};
1
2
3
4
5
6
7
8
9
10

使用此规则的正确示例：

/*eslint no-unsafe-finally: "error"*/
let foo = function() {
    try {
        return 1;
    } catch(err) {
        return 2;
    } finally {
        console.log("hola!");
    }
};
1
2
3
4
5
6
7
8
9
10

/*eslint no-unsafe-finally: "error"*/
let foo = function() {
    try {
        return 1;
    } catch(err) {
        return 2;
    } finally {
        let a = function() {
            return "hola!";
        }
    }
};
1
2
3
4
5
6
7
8
9
10
11
12

/*eslint no-unsafe-finally: "error"*/
let foo = function(a) {
    try {
        return 1;
    } catch(err) {
        return 2;
    } finally {
        switch(a) {
            case 1: {
                console.log("hola!")
                break;
            }
        }
    }
};
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15

何时不用

如果你想允许在 finally 块中进行控制流操作，你可以关闭这个规则。

Version

This rule was introduced in ESLint v2.9.0.

Resources

• Rule source
• Tests source